Skip to content

Conversation

@Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim Jaeyoung-Lim commented Dec 11, 2025

Problem Description
This PR adds an ocean world that can be useful for testing boats

image

Copy link
Member

@Pedro-Roque Pedro-Roque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need the gz::sim plugins and the buoyancy plugin in https://github.com/PX4/PX4-gazebo-models/blob/main/worlds/underwater.sdf ?

Copy link
Member Author

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minus the license on the model.

<name>Boat</name>
<version>1.0</version>
<sdf version='1.5'>boat.sdf</sdf>
<license>Apache 2.0</license>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have a license issue here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think is the best way to address it? It is ported over from old gazebo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to either change the license of this repo or we need to ask the original authors to relicense it for us

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll reach out to the authors and see if we can go in that direction.

Copy link
Member Author

@Jaeyoung-Lim Jaeyoung-Lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, minus the license on the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants