-
Notifications
You must be signed in to change notification settings - Fork 178
Add ocean world #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add ocean world #129
Conversation
Pedro-Roque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need the gz::sim plugins and the buoyancy plugin in https://github.com/PX4/PX4-gazebo-models/blob/main/worlds/underwater.sdf ?
Jaeyoung-Lim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, minus the license on the model.
| <name>Boat</name> | ||
| <version>1.0</version> | ||
| <sdf version='1.5'>boat.sdf</sdf> | ||
| <license>Apache 2.0</license> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have a license issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think is the best way to address it? It is ported over from old gazebo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to either change the license of this repo or we need to ask the original authors to relicense it for us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll reach out to the authors and see if we can go in that direction.
Jaeyoung-Lim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, minus the license on the model.
Problem Description
This PR adds an ocean world that can be useful for testing boats