Implemented QGC-Gazebo Parameter Sync Tools & Avl_automation Enhancements #79
Conversation
…piler' since the more robust surface definition is not compatible with the old yaml version This new tool helps make the simulation more accurate by importing from QGC the parameters and adding them to the gazebo sim This tool is not complete and turns Gazebo parameters back to a .param file for QGC
Copied an actual error from the gazebo output to better show and explain why do errors appear on the first simulation run
README was updated to reflect this change
There was a problem hiding this comment.
Thank you for the contribution!
-
Could you separate the two features to two different PRs?
-
I am not sure if I understand correctly the QGC2ROMFS feature. Wouldnt this be agnostic to the simulator used, and simply a separate tool for px4? Why is this useful for gazebo?
|
Hi @Jaeyoung-Lim, Thank you for your reply. I’ve only used Gazebo Classic, so I hadn’t considered the versatility of QGC2ROMFS across different simulators. As long as the parameter definition format remains consistent across all simulators, then yes! Both QGC2ROMFS and ROMFS2QGC will have a PR submitted to PX4, with only the updated AVL_automation remaining specific to Gazebo. |
tools/.vscode/c_cpp_properties.json
Outdated
| } | ||
| ], | ||
| "version": 4 | ||
| } |
There was a problem hiding this comment.
Please remove vscode artifacts from the PR
tools/.vscode/settings.json
Outdated
| "/opt/ros/humble/lib/python3.10/site-packages", | ||
| "/opt/ros/humble/local/lib/python3.10/dist-packages" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Same here, I don't think this should be part of the PR
|
@Filipe-Cavalheiro There seems to be vscode artifacts and pycache submitted as part of the PR. After these are removed, I can review the PR |
|
Hi @Jaeyoung-Lim,
To be completely honest, I do believe that the AVL automation with multiple control surfaces per wing is functional. However, I haven’t been able to create a YAML file for AVL that I’m fully satisfied with. This is mainly because aerodynamics are outside my area of expertise so I believe that my definition of the wings (easy_glider4) is not totally correct. |
|
Assuming this changes the way the AVL tool is run, would be great if we could have a docs update after this merges: https://docs.px4.io/main/en/sim_gazebo_gz/tools_avl_automation.html#advanced-lift-drag-avl-automation-tool |
Two new tools were implemented and one was updated
Summary
This pull request introduces two new tools and an update to Avl_automation, aiming to improve simulation accuracy and enhance aerodynamic modeling.
New Tool: QGC2ROMFS_parameters
New Tool: ROMFS2QGC_parameters (In Development)
Updated Tool: Avl_automation
Feedback & Next Steps
Any feedback is appreciated to ensure a smooth integration of these improvements. Let me know if anything needs adjustment!