Skip to content

Drop unmaintained reactor-error-prone dependency #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 19, 2025
Merged

Drop unmaintained reactor-error-prone dependency #1650

merged 2 commits into from
Apr 19, 2025

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Apr 19, 2025 •
edited
Loading

Suggested commit message:

Drop unmaintained `reactor-error-prone` dependency (#1650)

This dependency is incompatible with Error Prone 2.38.0. By dropping it, 
the `non-maven-central` Maven profile and Jitpack mirror can also be
dropped.

@Stephan202 Stephan202 added the chore A task not related to code (build, formatting, process, ...) label Apr 19, 2025
@Stephan202 Stephan202 added this to the 0.23.0 milestone Apr 19, 2025
@Stephan202 Stephan202 mentioned this pull request Apr 19, 2025
Merged
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 mentioned this pull request Apr 19, 2025
Merged
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

mohamedsamehsalah
mohamedsamehsalah approved these changes Apr 19, 2025
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@rickie rickie force-pushed the sschroevers/drop-reactor-error-prone branch from ba9b42a to d9950c3 Compare April 19, 2025 19:19
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 @rickie
Drop unmaintained reactor-error-prone dependency
a82e474 
This dependency is incompatible with Error Prone 2.38.0. By dropping it,
the `non-maven-central` Maven profile and Jitpack mirror can also be
dropped.
@Stephan202 @rickie
Drop remaining references to Jitpack
510d2de
@rickie rickie force-pushed the sschroevers/drop-reactor-error-prone branch from d9950c3 to 510d2de Compare April 19, 2025 19:24
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rickie rickie merged commit 3f24273 into master Apr 19, 2025
17 checks passed
@rickie rickie deleted the sschroevers/drop-reactor-error-prone branch April 19, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickie rickie rickie approved these changes

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

Assignees

No one assigned

Labels

chore A task not related to code (build, formatting, process, ...)

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Stephan202 @rickie @mohamedsamehsalah