Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use find_package instead of pkg-config to find dreal #3768

Closed
wants to merge 3 commits into from
Closed

Use find_package instead of pkg-config to find dreal #3768

wants to merge 3 commits into from

Conversation

jamiesnape
Copy link
Contributor

@jamiesnape jamiesnape commented Oct 11, 2016 •
edited by david-german-tri
Loading

This change is Reviewable

@jamiesnape jamiesnape self-assigned this Oct 11, 2016
@soonho-tri
Copy link
Member

soonho-tri commented Oct 11, 2016 •
edited
Loading

@jamiesnape, could you update dReal Hash in this PR? You can use cb43862a34f28d88a842d42d72d822f0bbaca0ea.

@jamiesnape
Copy link
Contributor Author

Done, thanks.

@jamiesnape
Copy link
Contributor Author

@drake-jenkins-bot linux-gcc-ninja-experimental please
@drake-jenkins-bot mac-clang-experimental please
@drake-jenkins-bot mac-clang-ninja-experimental please

@jamiesnape
Copy link
Contributor Author

jamiesnape commented Oct 14, 2016 •
edited
Loading

@soonho-tri How problematic would it be to install dreal and dependencies into ${prefix}/lib instead of ${prefix}/lib/dreal?

(it is kind of avoiding the real problem, not sure I will be able to fix that quickly)

@soonho-tri
Copy link
Member

soonho-tri commented Oct 14, 2016 •
edited
Loading

@jamiesnape, I'll do that. (or at least provide an option for LIB_PREFIX so that things go to lib/<LIB_PREFIX>/ if LIB_PREFIX is not null).

@jamiesnape
Copy link
Contributor Author

Thanks.

@jamiesnape
Copy link
Contributor Author

I will revisit this after dreal/dreal3#311 is resolved.

@jamiesnape jamiesnape closed this Oct 21, 2016
@jamiesnape jamiesnape deleted the find-package-dreal branch October 21, 2016 14:22
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: do not merge status: do not review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamiesnape @soonho-tri