Skip to content

Send uuid on app version create to do app matching #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alfonso-noriega
Copy link
Contributor

@alfonso-noriega alfonso-noriega commented Jul 14, 2025

WHY are these changes introduced?

Enable proper identification and matching of extensions during deployment while transitioning to the new dev platform.

WHAT is this pull request doing?

  • Adds UUID support to app manifests (so the backend can identify the module and migrate them)
  • Improves extension matching logic to handle both UUID and the new UID matching.
  • Updates local extensions with remote UIDs when matches are confirmed
  • Stops writing the .env files to disk.

How to test your changes?

To verify everything still works fine with Partners:

  • Do some deploys adding, updating and deleting extensions.
  • See that everything works as always.

To verify the new behavior in the new Dev Platform (running locally):

  • Create a new app with some extensions and make a deploy
  • Edit the local DB and remove the user_identifier from the corresponding table
  • Try to make a new deploy:
    • All extensions should still be matched automatically.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

alfonso-noriega commented Jul 14, 2025

@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch 2 times, most recently from 1f6d859 to d3f1f29 Compare July 15, 2025 11:45
@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch from d3f1f29 to 5099ba9 Compare July 15, 2025 13:29
Copy link
Contributor

github-actions bot commented Jul 15, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.96% (+0.02% 🔼)
13005/16682
🟡 Branches
72.11% (+0.04% 🔼)
6342/8795
🟡 Functions
78.11% (+0.02% 🔼)
3373/4318
🟡 Lines
78.36% (+0.02% 🔼)
12314/15714
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / identifiers.ts
100%
90% (-0.48% 🔻)
100% 100%
🟢
... / id-matching.ts
98.02% (-0.92% 🔻)
78.57% (-4.76% 🔻)
100%
98.77% (-1.23% 🔻)

Test suite run success

3044 tests passing in 1314 suites.

Report generated by 🧪jest coverage report action from 7a09ce3

@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch from 5099ba9 to 0941461 Compare July 15, 2025 13:44
@alfonso-noriega alfonso-noriega marked this pull request as ready for review July 15, 2025 14:33
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 15, 2025 14:33
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch from 0941461 to df98fb0 Compare July 16, 2025 08:16
@isaacroldan isaacroldan force-pushed the 07-14-send_uuid_on_app_version_create_to_do_app_matching branch from df98fb0 to 7a09ce3 Compare July 21, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants