-
Notifications
You must be signed in to change notification settings - Fork 191
Show updated modules when migrating them to the new dev platform #6135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 07-16-show_list_of_added_uids_on_the_first_deploy
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d991189
to
2541a54
Compare
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
63a75d3
to
e2c3555
Compare
Coverage report
Test suite run success3046 tests passing in 1315 suites. Report generated by 🧪jest coverage report action from e2c3555 |
e2c3555
to
ebc796a
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/function.d.ts@@ -1,4 +1,4 @@
-import type { DebouncedFunc, DebounceSettings, ThrottleSettings } from 'lodash';
+import type { DebouncedFunc, DebounceSettings } from 'lodash';
/**
* Creates a function that memoizes the result of func. If resolver is provided it determines the cache key for
* storing the result based on the arguments provided to the memoized function. By default, the first argument
@@ -20,25 +20,11 @@ export declare function memoize<T extends (...args: any) => any>(func: T, resolv
* Note: If leading and trailing options are true, func is invoked on the trailing edge of the timeout only
* if the the debounced function is invoked more than once during the wait timeout.
*
- * See David Corbacho's article for details over the differences between _.debounce and _.throttle.
+ * See David Corbacho’s article for details over the differences between _.debounce and _.throttle.
*
* @param func - The function to debounce.
* @param wait - The number of milliseconds to delay.
* @param options - The options object.
* @returns Returns the new debounced function.
*/
-export declare function debounce<T extends (...args: any) => any>(func: T, wait?: number, options?: DebounceSettings): DebouncedFunc<T>;
-/**
- * Creates a throttled function that only invokes func at most once per every wait milliseconds.
- * The throttled function comes with a cancel method to cancel delayed invocations and a flush method to immediately invoke them.
- * Provide an options object to indicate whether func should be invoked on the leading and/or trailing edge of the wait timeout.
- * Subsequent calls to the throttled function return the result of the last func invocation.
- *
- * See David Corbacho's article for details over the differences between _.debounce and _.throttle.
- *
- * @param func - The function to throttle.
- * @param wait - The number of milliseconds to throttle invocations to.
- * @param options - The options object.
- * @returns Returns the new throttled function.
- */
-export declare function throttle<T extends (...args: any) => any>(func: T, wait?: number, options?: ThrottleSettings): DebouncedFunc<T>;
\ No newline at end of file
+export declare function debounce<T extends (...args: any) => any>(func: T, wait?: number, options?: DebounceSettings): DebouncedFunc<T>;
\ No newline at end of file
|
WHY are these changes introduced?
To improve the clarity of extension deployment information by properly categorizing extensions as "unchanged" or "updated" in the deployment prompt.
WHAT is this pull request doing?
This PR refines how extensions are categorized during deployment:
unchanged
field to theExtensionIdentifiersBreakdown
interfaceONLY extensions that are being "migrated" to dev dash and adding a UID are shown as
UPDATED
How to test your changes?
To force a extension to be migrated, running everything locally, delete the
user_identifier
from an extension in the active version in the Database.Measuring impact
How do we know this change was effective? Please choose one:
Checklist