Skip to content

Show list of added UIDs on the first deploy #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 07-15-remove_migratelegacyfunctions
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jul 16, 2025

WHY are these changes introduced?

To improve the user experience by providing visual feedback when extension IDs are generated during the ID matching process.

WHAT is this pull request doing?

Adds visual feedback when extension IDs are generated during the ID matching process. The PR:

  • Separates matched extensions by their matching method (UID, UUID, name)
  • Adds a colorful output that shows when new extension IDs are generated

Captura de pantalla 2025-07-16 a las 13.34.08.png

How to test your changes?

Having an app in the new dev platform running locally, go into the DB and remove the user_identifier values of the last version of each extension.

  1. Run a command that triggers the ID matching process (e.g., shopify app deploy)
  2. Observe the new colorful output showing which extensions have IDs generated
  3. Verify that extensions matched by UUID or name (not UID) are properly displayed in the output

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jul 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.95% (-0.27% 🔻)
12992/16667
🟡 Branches
72.14% (-0.29% 🔻)
6339/8787
🟡 Functions
78.1% (-0.08% 🔻)
3370/4315
🟡 Lines
78.35% (-0.28% 🔻)
12302/15701
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / liquid-tag-content.ts
91.67% 75% 100% 91.67%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app.ts
86.24% (-0.53% 🔻)
68.22% (-2.8% 🔻)
93.44%
88.34% (-0.61% 🔻)
🟡
... / extension-instance.ts
78.13% (-7.08% 🔻)
74.29% (-7.97% 🔻)
91.07% (-1.52% 🔻)
77.53% (-7.63% 🔻)
🟢
... / patch-app-configuration-file.ts
93.33% (-6.67% 🔻)
100% (+20% 🔼)
85.71% (-14.29% 🔻)
93.33% (-6.67% 🔻)
🔴
... / extension.ts
56.45% (-1.88% 🔻)
60%
44.44% (-5.56% 🔻)
57.38% (-1.94% 🔻)
🟡
... / build.ts
71.74% (-7.97% 🔻)
58.7% (-4.35% 🔻)
69.05% (-4.76% 🔻)
70.77% (-7.69% 🔻)
🟢
... / common.ts
90.91% (+7.58% 🔼)
91.67% (+13.1% 🔼)
71.43% (-3.57% 🔻)
89.47% (+8.52% 🔼)
🔴
... / partners-client.ts
24.7% (-1.09% 🔻)
26.09% (-3.91% 🔻)
17.74% (-0.29% 🔻)
24.53% (-0.96% 🔻)
🟢
... / errors.ts
94.74% (-2.23% 🔻)
85.71% (-0.95% 🔻)
100%
94.74% (-2.23% 🔻)
🔴
... / theme-command.ts
38.78% (-4.62% 🔻)
12.5% (-6.73% 🔻)
40%
42.22% (-4.72% 🔻)
🟢
... / local-assets.ts
91.36% (-0.69% 🔻)
73.58% (-1.85% 🔻)
100%
93.51% (-0.54% 🔻)
🟢
... / server.ts
82.9% (-0.84% 🔻)
75.34% (-0.66% 🔻)
87.5% (-0.38% 🔻)
83.24% (-0.83% 🔻)

Test suite run success

3045 tests passing in 1315 suites.

Report generated by 🧪jest coverage report action from d4e93f6

@isaacroldan isaacroldan force-pushed the 07-16-show_list_of_added_uids_on_the_first_deploy branch from 82aba8f to 41d82e0 Compare July 16, 2025 13:45
@isaacroldan isaacroldan marked this pull request as ready for review July 16, 2025 14:51
@isaacroldan isaacroldan requested a review from a team as a code owner July 16, 2025 14:51
Copy link
Contributor

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@isaacroldan isaacroldan force-pushed the 07-16-show_list_of_added_uids_on_the_first_deploy branch from 41d82e0 to 19dbb3a Compare July 16, 2025 14:56
@isaacroldan isaacroldan force-pushed the 07-16-show_list_of_added_uids_on_the_first_deploy branch from 19dbb3a to d4e93f6 Compare July 21, 2025 09:41
@isaacroldan isaacroldan force-pushed the 07-15-remove_migratelegacyfunctions branch from b5ba43f to 46089a7 Compare July 21, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant