Skip to content

Remove org_id from app management URL #6137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jul 21, 2025

WHY are these changes introduced?

Support removing the org_id from the app tomls.

WHAT is this pull request doing?

  • Remove ORG_ID from app managament API URLs.
    Refactor all calls to the app management API to not include the organization ID.
    Add organizationId to the requested fields when fetching an app detail.

  • Add ORG_ID as a variable for some queries/mutations
    And update some to include it as part of the variables when the query/mutation is at the org level (like CreateApp),

How to test your changes?

  1. Just use the CLI, check that the flow of creating an app, adding extensions and deploying all works.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jul 21, 2025

Copy link
Contributor

github-actions bot commented Jul 21, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.94% (+0% 🔼)
13006/16687
🟡 Branches
72.12% (+0.06% 🔼)
6342/8794
🟡 Functions 78.1% 3371/4316
🟡 Lines
78.35% (+0% 🔼)
12316/15720
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / loader.ts
93.36% (-0.03% 🔻)
85.92% (-0.14% 🔻)
97.27%
94.34% (-0.03% 🔻)
🔴
... / app-management-client.ts
47.24% (-0.15% 🔻)
43.06% 43.64%
46.2% (-0.15% 🔻)

Test suite run success

3045 tests passing in 1314 suites.

Report generated by 🧪jest coverage report action from 27d6970

@isaacroldan isaacroldan force-pushed the 07-21-remove_org_id_from_app_management_url branch from 3de7922 to 27d6970 Compare July 22, 2025 12:22
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/app-management.d.ts
@@ -22,7 +22,6 @@ export interface RequestOptions {
  * @param unauthorizedHandler - Optional handler for unauthorized requests.
  */
 export interface AppManagementRequestOptions<TResult, TVariables extends Variables> {
-    organizationId: string;
     query: TypedDocumentNode<TResult, TVariables>;
     token: string;
     variables?: TVariables;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant