Make developerPlatformClient not optional in OrganizationApp

[isaacroldan]

WHY are these changes introduced?

Support the project to remove ORG_ID from app tomls.

WHAT is this pull request doing?

Changes the developerPlatformClient property on the OrganizationApp type from optional to required, and updates all relevant code to ensure this property is always provided. This eliminates the need for fallback logic when accessing the developer platform client.

How to test your changes?

1. Just make sure the CLI works, creating an app, adding extensions, deploying...

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
• Existing analytics will cater for this addition
• PR includes analytics changes to measure impact

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[isaacroldan]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Make developerPlatformClient not optional in OrganizationApp #6144 👈 (View in Graphite)
• Stop loading organization_id from toml and using it to select the client #6143
• Remove org_id from app management URL #6137
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/app-management.d.ts

@@ -22,7 +22,6 @@ export interface RequestOptions {
  * @param unauthorizedHandler - Optional handler for unauthorized requests.
  */
 export interface AppManagementRequestOptions<TResult, TVariables extends Variables> {
-    organizationId: string;
     query: TypedDocumentNode<TResult, TVariables>;
     token: string;
     variables?: TVariables;

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	77.97% (-0% 🔻)	12993/16664
🟡	Branches	72.11% (+0.02% 🔼)	6332/8781
🟡	Functions	78.09%	3368/4313
🟡	Lines	78.37% (-0% 🔻)	12304/15699

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / app-context.ts	96.67% (-0.11% 🔻)	92.31% (+3.02% 🔼)	100%	96.55% (-0.11% 🔻)
🟢	... / context.ts	78.13% (-0.23% 🔻)	58.82%	77.27%	80.23% (-0.23% 🔻)
🟢	... / link.ts	96.51% (-0.04% 🔻)	94.12% (+2.45% 🔼)	100%	96.34% (-0.04% 🔻)

Test suite run success

3042 tests passing in 1314 suites.

Report generated by 🧪jest coverage report action from b68ef39

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/app-management.d.ts

@@ -22,7 +22,6 @@ export interface RequestOptions {
  * @param unauthorizedHandler - Optional handler for unauthorized requests.
  */
 export interface AppManagementRequestOptions<TResult, TVariables extends Variables> {
-    organizationId: string;
     query: TypedDocumentNode<TResult, TVariables>;
     token: string;
     variables?: TVariables;