Skip to content

Stop loading organization_id from toml and using it to select the client #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 07-21-remove_org_id_from_app_management_url
Choose a base branch
from

Conversation

isaacroldan
Copy link
Contributor

@isaacroldan isaacroldan commented Jul 22, 2025

WHY are these changes introduced?

Support removing the ORG_ID from the apps toml.
This PR actually stops loading it.

WHAT is this pull request doing?

  • Removes the organization_id field from the app schema (we won't load it anymore)
  • Set includeConfigOnDeploy to true by default if not specified already in the config. In preparation for the migration where it will be true always.
  • Updates the appFromIdentifiers function, now it will try to fetch the app from all clients and return the first that succeeds.
  • Other simplifications and clean ups.

How to test your changes?

  1. Just make sure everything still works, creating an app, adding extensions, deploying... in both a partners app and a dev dash app.

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor Author

isaacroldan commented Jul 22, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@isaacroldan isaacroldan force-pushed the 07-22-stop_loading_organization_id_from_toml_and_using_it_to_select_the_client branch from dd7eaf5 to ffd5cbb Compare July 22, 2025 12:22
@isaacroldan isaacroldan force-pushed the 07-21-remove_org_id_from_app_management_url branch from 3de7922 to 27d6970 Compare July 22, 2025 12:22
@isaacroldan isaacroldan force-pushed the 07-22-stop_loading_organization_id_from_toml_and_using_it_to_select_the_client branch from ffd5cbb to e4030c4 Compare July 22, 2025 15:38
@isaacroldan isaacroldan force-pushed the 07-22-stop_loading_organization_id_from_toml_and_using_it_to_select_the_client branch from e4030c4 to 7d025ec Compare July 22, 2025 15:59
Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/app-management.d.ts
@@ -22,7 +22,6 @@ export interface RequestOptions {
  * @param unauthorizedHandler - Optional handler for unauthorized requests.
  */
 export interface AppManagementRequestOptions<TResult, TVariables extends Variables> {
-    organizationId: string;
     query: TypedDocumentNode<TResult, TVariables>;
     token: string;
     variables?: TVariables;

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.97% 12996/16667
🟡 Branches 72.1% 6335/8787
🟡 Functions 78.09% 3368/4313
🟡 Lines 78.38% 12307/15702

Test suite run success

3042 tests passing in 1314 suites.

Report generated by 🧪jest coverage report action from 7d025ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant