fix(apps): align txn types #1138
Open
+257
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: f817712 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alexfreska
force-pushed
the
fix_apps_align_contract_resolution_types
branch
from
84544ca to
76c9487
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes contract resolution types across V1 and V2 transactions, introduces a new contractRefresh case when a renewal doesn’t change the contract, and updates related type definitions and explorer components to use the new patterns.
- Refactor and split
getTransactionTypeintogetV1TransactionTypeandgetV2TransactionType, addingcontractRefreshlogic. - Rename resolution kinds from
"storage proof"to"storageProof"and adjust type definitions in@siafoundation/types. - Update
Transaction.arbitraryDatashapes and propagate changes into explorer converters and components.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/units/src/transactionTypes.ts | Introduced getV1TransactionType/getV2TransactionType, added contractRefresh, updated mappings |
| libs/types/src/v2.ts | Renamed and consolidated V2FileContractResolution types, standardized storageProof naming |
| libs/types/src/core.ts | Changed Transaction.arbitraryData from string[] to string[][] |
| libs/explored-types/src/types.ts | Adjusted ExplorerTransaction.arbitraryData from string[][] to string[] |
| apps/explorer/lib/tx.ts | Added helper to convert ExplorerV2Transaction into parameters for getV2TransactionType |
| apps/explorer/components/Transaction/index.tsx | Swapped title prop for txType on Transaction component |
| apps/explorer/components/Transaction/TransactionHeader.tsx | Added a badge showing txType and updated header layout |
| apps/explorer/components/Entity/EntityListItem.tsx | Replaced getTransactionType with getV1TransactionType and new V2 conversion helper |
| apps/explorer/components/ContractView/index.tsx | Pass txType instead of hardcoded title for formation transactions |
| apps/explorer/app/(main)/tx/[id]/page.tsx | Imported and used getV1TransactionType/getV2TransactionType to set txType prop |
| .changeset/quick-avocados-accept.md | Documented a patch for @siafoundation/types fixing resolution types |
| .changeset/old-gorillas-shout.md | Announced support for the new contractRefresh event |
Comments suppressed due to low confidence (2)
libs/units/src/transactionTypes.ts:118
- [nitpick] The new
contractRefreshpath ingetV2TransactionTypeshould have dedicated unit tests for both equal and non-equal height scenarios to prevent regressions.
: 'contractRenewal'
libs/types/src/core.ts:152
- Changing
arbitraryDatafromstring[]tostring[][]is a breaking change; ensure all consumers (including V1 handlers) are updated to handle the new shape.
arbitraryData?: string[][]
76c9487 to
abb26b1
Compare
alexfreska
force-pushed
the
fix_apps_align_contract_resolution_types
branch
from
abb26b1 to
e717f7b
Compare
alexfreska
force-pushed
the
fix_apps_align_contract_resolution_types
branch
from
e717f7b to
062d9ce
Compare
alexfreska
changed the title
alexfreska
force-pushed
the
fix_apps_align_contract_resolution_types
branch
from
062d9ce to
f817712
Compare
alexfreska
changed the base branch from
graphite-base/1138
to
fix_renterd-e2e_flaky_wallet_tests
This was referenced Jun 27, 2025
peterjan
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
renterd / hostd / walletd
explorer