Skip to content

fix(renterd-e2e): flaky wallet tests #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: refactor_explorer-e2e_simplify_startcluster
Choose a base branch
from

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jun 27, 2025

  • This reliably fixes the main two flaky tests that become flaky after we reduced maturityheights and sped things up.
  • For some reason mine(1) is required, I would think that the m.MineBlocks(ctx, int(network.MaturityDelay)+20 mining in StartRenterd would be enough.

Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:37pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:37pm
hostd ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:37pm
renterd ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:37pm

@github-project-automation github-project-automation bot moved this to In Progress in Sia Jun 27, 2025
Copy link
Member Author

alexfreska commented Jun 27, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@alexfreska alexfreska force-pushed the refactor_explorer-e2e_simplify_startcluster branch from 7a133e1 to 5eb4cb3 Compare June 27, 2025 18:36
@alexfreska alexfreska force-pushed the fix_renterd-e2e_flaky_wallet_tests branch from 6d207c5 to 407231f Compare June 27, 2025 18:36
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: 407231f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: 407231f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@chris124567 chris124567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the MaturityHeight to 9 instead of 10 do you have to mine(2) for those to pass? It seems odd that you have to mine again given that it seems in most places we mine blocks, we mine in terms of the maturity height. Anyways other than that I approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants