Skip to content

refactor(explorer-e2e): simplify startcluster #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexfreska
Copy link
Member

@alexfreska alexfreska commented Jun 27, 2025

  • Recently much of this logic was added into library method setupCluster, this refactors startCluster to use this.

@Copilot Copilot AI review requested due to automatic review settings June 27, 2025 18:32
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: 5eb4cb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:36pm
explorer-zen ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:36pm
hostd ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:36pm
renterd ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2025 6:36pm

@github-project-automation github-project-automation bot moved this to In Progress in Sia Jun 27, 2025
Copy link
Member Author

alexfreska commented Jun 27, 2025

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the explorer-e2e cluster start-up process and updates the wasm_exec.js file path in the SDK configuration.

  • Simplifies cluster initialization by using the cluster object returned from setupCluster.
  • Updates the file copy command to reference a new wasm_exec.js location.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/sdk/project.json Updated the file copy command to use a new wasm_exec.js path.
apps/explorer-e2e/src/fixtures/cluster.ts Simplified the cluster startup logic by removing manual filtering and error checks.
Comments suppressed due to low confidence (2)

libs/sdk/project.json:17

  • Verify that the updated path for wasm_exec.js reflects the correct location based on the current Go environment, ensuring consistency with the project's requirements.
          "cp $(go env GOROOT)/lib/wasm/wasm_exec.js libs/sdk/src/utils/wasm_exec.js",

apps/explorer-e2e/src/fixtures/cluster.ts:19

  • Confirm that the removal of manual node filtering and error checks is fully covered by integration tests to ensure the cluster setup is robust.
  const cluster = await setupCluster({

@alexfreska alexfreska force-pushed the refactor_explorer-e2e_simplify_startcluster branch from 7a133e1 to 5eb4cb3 Compare June 27, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants