-
Notifications
You must be signed in to change notification settings - Fork 12
refactor(explorer-e2e): simplify startcluster #1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the explorer-e2e cluster start-up process and updates the wasm_exec.js file path in the SDK configuration.
- Simplifies cluster initialization by using the cluster object returned from setupCluster.
- Updates the file copy command to reference a new wasm_exec.js location.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
libs/sdk/project.json | Updated the file copy command to use a new wasm_exec.js path. |
apps/explorer-e2e/src/fixtures/cluster.ts | Simplified the cluster startup logic by removing manual filtering and error checks. |
Comments suppressed due to low confidence (2)
libs/sdk/project.json:17
- Verify that the updated path for wasm_exec.js reflects the correct location based on the current Go environment, ensuring consistency with the project's requirements.
"cp $(go env GOROOT)/lib/wasm/wasm_exec.js libs/sdk/src/utils/wasm_exec.js",
apps/explorer-e2e/src/fixtures/cluster.ts:19
- Confirm that the removal of manual node filtering and error checks is fully covered by integration tests to ensure the cluster setup is robust.
const cluster = await setupCluster({
7a133e1
to
5eb4cb3
Compare
setupCluster
, this refactorsstartCluster
to use this.