Add common command CIs #3449
Add common command CIs #3449
Conversation
Lmh-java
force-pushed
the
minghao/new-ci
branch
from
6c5a11a to
06df1b7
Compare
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
| common-commands: | ||
| strategy: | ||
| # TODO: set fail-fast to true in production. |
There was a problem hiding this comment.
remember to remove TODO before merging
| - ../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- --enable_autoref --ci_mode && ../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- blue_log="$(find /tmp/tbots/blue -maxdepth 1 -type d -name 'proto_*' -printf '/tmp/tbots/blue/%f\n' 2>/dev/null | head -n1)" | ||
|
|
||
| name: Sanity Check on Common Commands | ||
| runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
you can use the ubuntu-22.04 runner
| commands: | ||
| - ../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- --run_blue --run_diagnostics --interface lo --keyboard_estop --ci_mode | ||
| - ../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/ai/hl/stp/tactic/goalie:goalie_tactic_test -- --enable_thunderscope | ||
| - ../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- --enable_autoref --ci_mode && ../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- blue_log="$(find /tmp/tbots/blue -maxdepth 1 -type d -name 'proto_*' -printf '/tmp/tbots/blue/%f\n' 2>/dev/null | head -n1)" |
There was a problem hiding this comment.
what does the second half of this command do?
There was a problem hiding this comment.
Sorry for the delay, I am finally done work.
../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- --enable_autoref --ci_mode This first half runs thunderscope once
This part tries to find the previous replay log and display the logs:
../scripts/safe_run.sh bazel run --run_under="xvfb-run" //software/thunderscope:thunderscope_main -- blue_log="$(find /tmp/tbots/blue -maxde4pth 1 -type d -name 'proto_*' -printf '/tmp/tbots/blue/%f\n' 2>/dev/null | head -n1)
This is not ideal, I am trying to think of a way to handle this. Maybe I should allow a new argument for our thunderscope, so we can specify the location for the replay log to save, so that we don't need to lookup for it.
There was a problem hiding this comment.
yeah being able to specify the runtime dir + folder name would be ideal
| @@ -0,0 +1,52 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
safe_run.sh is sort of a weird name that doesn't immediately tell you what this file does
But tbh I don't know a better name... maybe ci_runner.sh is better. At least it tells you that it's only relevant for CI.
| @@ -0,0 +1,52 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Add a high-level description of this script at the top of this file.
| @@ -0,0 +1,52 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
If you re-write this script with python, you can use subprocess and get stdout and stderr logs. Then, you can print the error messages. Because right now, there isn't any feedback for the developers and it will be confusing when this CI job suddenly fails.
There was a problem hiding this comment.
Sure, sounds good!
I was trying to use 2> and > to redirect stdout and stderr, but it didn't seem to work.
itsarune
left a comment
itsarune
left a comment
There was a problem hiding this comment.
looks awesome! left some interim feedback for you
| if len(sys.argv) < 2: | ||
| print("Usage: command_runner.py <command> [args...]", file=sys.stderr) | ||
| sys.exit(1) | ||
|
|
||
| command = sys.argv[1:] |
There was a problem hiding this comment.
better to use the argparse module here, it's more standard for python. it can also let you take in an arbitrary number of inputs.
itsarune
left a comment
itsarune
left a comment
There was a problem hiding this comment.
looks good, I think you just need to update the workflow YAMLs and then it should work
| ) | ||
|
|
||
| # Proto log folder name | ||
| parser.add_argument( |
2 participants
Description
Add a python script that dry-runs some of our common CLI commands (as some sort of E2E integration test)
Testing Done
Resolved Issues
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue