Use ESM JSON imports instead of adhoc json imports #34176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Build Tooling
youknowriad
requested review from
adamziel,
ajitbohra,
chrisvanpatten,
draganescu,
kevin940726,
mkaz,
mkevins,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
youknowriad
changed the title
|
Size Change: 0 B Total Size: 1.04 MB ℹ️ View Unchanged
|
|
I will have a look at the issue you mentioned. https://github.com/tc39/proposal-import-assertions - noting that this feature it's still stage 3, so it isn't a JavaScript standard. Unless, it was promoted to stage 4 and the repository didn't get a refresh. |
gziolo
force-pushed
the
update/use-json-esm-imports
branch
from
595912d
to
4057c22
Compare
|
I fixed the lock file in 4057c22 and linter runs again. It shows an error though:
|
gziolo
added
[Tool] ESLint plugin
|
We would be able to remove the Babel plugin that inlines JSON files: Line 6 in 914f543 Line 5 in 914f543 According to my testing, we will have to copy JSON files to There is also this question what would happen to: gutenberg/bin/packages/build.js Lines 148 to 156 in 914f543 |
|
I'm happy to see it happen, but I think we should wait until the spec is standardized or until the tooling catch up. 👍 |
This was referenced Nov 22, 2021
|
Closing this PR JSON imports are still stage 3, it's taking so much time :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36142 and #36716.
For some time now, we've been using a custom JSON import to load block metadata in JS. Now that JSON modules are being standardized, we should switch to the standard syntax which would allow us to avoid lockin.
This seems to work well aside eslint. I was not able to make eslint work without issues here. Any help would be appreciated.