Combine into VPUSH for s16 and s32 as well #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinay-anubola
requested review from
abnikant,
andcarminati,
gbossu,
khallouh,
konstantinschwarz,
martien-de-jong,
SagarMaheshwari99 and
stephenneuendorffer
as code owners
gbossu
reviewed
Oct 31, 2024
abhinay-anubola
force-pushed
the
sanubola.extend.types.VInsertCombiner
branch
2 times, most recently
from
894850d to
6ebdd34
Compare
andcarminati
reviewed
Nov 5, 2024
abhinay-anubola
force-pushed
the
sanubola.extend.types.VInsertCombiner
branch
2 times, most recently
from
ebc4c0a to
ab1284c
Compare
|
This PR looks good! Do you have some QoR numbers? |
|
There is no change in QoR for now. |
abhinay-anubola
force-pushed
the
sanubola.extend.types.VInsertCombiner
branch
from
ab1284c to
35816ad
Compare
llvm/test/CodeGen/AIE/aie2/GlobalISel/combine-vinsert-sequence-prelegalizer.mir
Show resolved
Hide resolved
abhinay-anubola
force-pushed
the
sanubola.extend.types.VInsertCombiner
branch
from
35816ad to
2eee32c
Compare
abhinay-anubola
force-pushed
the
sanubola.extend.types.VInsertCombiner
branch
from
2eee32c to
c0151ce
Compare
martien-de-jong
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 16-bit and 32-bit VInserts in PreLegalizerCombiner