-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NpuSyncOp generation to AIEDmaToNpu #1114
base: main
Are you sure you want to change the base?
Changes from all commits
932eea6
f223798
9d9f618
9e6f582
812ec66
6642c30
fef09fd
3b88caf
1521c11
9fb0964
56cf237
0133741
6b05733
9f72509
5122553
6edffdc
5f98b63
56eddbb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,6 @@ def sequence(A, B, C): | |
npu_dma_memcpy_nd( | ||
metadata="in", bd_id=1, mem=A, sizes=[1, K, M, 1], strides=[1, 1, K] | ||
) | ||
npu_sync(column=0, row=0, direction=0, channel=0) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd prefer that the tests keep the sync explicit, but using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Should we close this PR in favor of #1791 ? Or is there still a desire to insert the sync/wait automatically? |
||
|
||
print(ctx.module) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to unconditionally add a sync to every outgoing memcpy. For example, what if we are collecting N output tiles at the shim and only need to sync at the end? The N-1 extraneous syncs will have a performance penalty vs. the single (manually inserted) sync at the end.