Change WireBundle::Ctrl to WireBundle::Control. Decouple WireBundle and StrmSwPortType. #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifield
requested review from
stephenneuendorffer and
AndraBisca
as code owners
|
replaced by #2010 |
There was a problem hiding this comment.
While I'm normally very much in favor of avoiding abbreviations, I'm not 100% on board with this. The WireBundle names come from the architecture and at some point it's not good to have that inconsistency. But I guess there has to be some friction somewhere, the only question is where is the least confusing place for it to be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes replaces the abbreviated
WireBundle::CtrlwithWireBundle::Controland removes an implicit coupling between theWireBundleenum names and the aie-rtStrmSwPortTypeenum names.Previously the xaie target (e.g.
aie-translate --aie-generate-xaie) used the TableGen'dwireBundleStringifyfunctions to emitStrmSwPortTypeenums directly as C++ source code. This PR replaces uses ofwireBundleStringifyinAIETargetXAIEV2with a new utility function. This corrects a potential bug related to thePLport and allows the renaming of the control port.