Skip to content

feat(obstacle_stop_module, motion_velocity_planner_common): add safety_factor to obstacle_stop module #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jul 15, 2025

Description

  1. change to store object uuid as unique_identifier_msgs type instead of string type
  2. add SafetyFactor

Related links

universe side: autowarefoundation/autoware_universe#10990

How was this PR tested?

tier4 scenario tests.

I've checked ros topic:
Screencast from 2025年07月15日 20時50分37秒.webm

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jul 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 50.65%. Comparing base (e295ccb) to head (acad4da).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
..._obstacle_stop_module/src/obstacle_stop_module.cpp 80.00% 2 Missing ⚠️
...nner/autoware_motion_velocity_planner/src/node.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
+ Coverage   47.38%   50.65%   +3.26%     
==========================================
  Files         312      315       +3     
  Lines       20086    20137      +51     
  Branches     8737     8904     +167     
==========================================
+ Hits         9518    10200     +682     
+ Misses       9742     9027     -715     
- Partials      826      910      +84     
Flag Coverage Δ *Carryforward flag
differential 40.77% <93.33%> (?)
total 47.41% <ø> (+0.02%) ⬆️ Carriedforward from 78054ec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/add-safety-factor branch from abb7995 to 78054ec Compare July 15, 2025 11:55
@yuki-takagi-66 yuki-takagi-66 added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 15, 2025
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review July 15, 2025 11:58
@takayuki5168
Copy link
Contributor

@yuki-takagi-66
Please add the unit test refeering to Odashima-san's safety_factor PRs.

@yuki-takagi-66 yuki-takagi-66 marked this pull request as draft July 17, 2025 10:54
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Signed-off-by: yuki-takagi-66 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants