Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async-lock requirement from 2.8 to 3.0 #10316

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2023

Updates the requirements on async-lock to permit the latest version.

Release notes

Sourced from async-lock's releases.

v3.0.0

  • Breaking: Add an enabled-by-default std feature that allows using this crate without the standard library. (#43)
  • Support blocking and non-blocking operations on the same locks. (#56)
  • Switch to a more efficient event notification mechanism. (#43)
Changelog

Sourced from async-lock's changelog.

Version 3.0.0

  • Breaking: Add an enabled-by-default std feature that allows using this crate without the standard library. (#43)
  • Support blocking and non-blocking operations on the same locks. (#56)
  • Switch to a more efficient event notification mechanism. (#43)

Version 2.8.0

  • Fix a bug where the SemaphoreGuard::acquire_arc future would busy wait under certain conditions (#42).
  • Add a Semaphore::add_permits() function to increase the number of available permits on the semaphore (#44).
  • Make RwLockReadGuard covariant over its lifetime (#45)
  • Add RwLockReadGuardArc, RwLockWriteGuardArc, and other reference counted guards for the RwLock type (#47).
  • Loosen the Send/Sync bounds on certain future types (#48).
  • Fix UB caused by the MutexGuardArc::source function allowing the user to drop an object in a different thread than the one it was acquired in (#50). This is a breaking change, but in the name of soundness. Therefore it doesn't break any valid behavior.
  • Fix a bug where this crate would not compile properly on wasm64 (#51).

Version 2.7.0

  • Replace some async blocks with manual futures (#34)
  • Remove our dependency on futures-lite (#36)
  • Mark guard types with #[clippy::has_significant_drop] (#37)

Version 2.6.0

  • Add OnceCell. (#27)
  • Support wasm64.

Version 2.5.0

  • Fix an issue where the future returned by Mutex::lock_arc/Semaphore::acquire_arc holds a reference to self. (#20, #21)

Version 2.4.0

  • Add WASM support. (#14)

Version 2.3.0

  • Merge all subcrates.

Version 2.2.0

  • Add functions to upgrade and downgrade RwLock guards.
  • Make all constructors const fn.

Version 2.1.3

  • Add #![forbid(unsafe_code)].

Version 2.1.2

... (truncated)

Commits
  • 8603347 v3.0.0
  • 604d461 feat: Support blocking and non-blocking operations on the same mutex
  • c788964 Merge pull request #43 from smol-rs/notgull/evl-v3.0.0
  • 3a82590 Add a default "std" feature for no_std usage
  • 8f8b4fe Bump to event-listener v3.0.0
  • c76dc08 Update actions/checkout action to v4
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [async-lock](https://github.com/smol-rs/async-lock) to permit the latest version.
- [Release notes](https://github.com/smol-rs/async-lock/releases)
- [Changelog](https://github.com/smol-rs/async-lock/blob/master/CHANGELOG.md)
- [Commits](smol-rs/async-lock@v2.8.0...v3.0.0)

---
updated-dependencies:
- dependency-name: async-lock
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the C-Dependencies A change to the crates that Bevy depends on label Oct 30, 2023
@mnmaita
Copy link
Member

mnmaita commented Nov 1, 2023

This is the reported breaking change for this version FWIW:

Breaking: Add an enabled-by-default std feature that allows using this crate without the standard library. (#43)

@mockersf
Copy link
Member

mockersf commented Nov 1, 2023

should maybe be updated with async-fs

@mnmaita
Copy link
Member

mnmaita commented Nov 4, 2023

I've done that here.

@alice-i-cecile
Copy link
Member

Closing in favor of #10370.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 4, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/async-lock-3.0 branch November 4, 2023 18:47
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2023
# Objective

- Closes #10316

## Solution

- Grouped a bunch of version requirement bumps for most of the `async`
crates.
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
…0370)

# Objective

- Closes bevyengine#10316

## Solution

- Grouped a bunch of version requirement bumps for most of the `async`
crates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants