-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bevy_ui/layout] Handle ui heirchy change edge cases #13360
Closed
StrikeForceZero
wants to merge
48
commits into
bevyengine:main
from
StrikeForceZero:dev/bevy_ui/ui_surface_promo_demo
Closed
[bevy_ui/layout] Handle ui heirchy change edge cases #13360
StrikeForceZero
wants to merge
48
commits into
bevyengine:main
from
StrikeForceZero:dev/bevy_ui/ui_surface_promo_demo
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeForceZero
commented
May 13, 2024
@@ -158,6 +160,82 @@ pub fn ui_layout_system( | |||
} | |||
} | |||
|
|||
for new_root_node_entity in removed_parents.read() { | |||
// TODO: most of this should be moved into a function on `UiSurface` but the query requirements might feel out of place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was planning on moving this logic into an associated function on UiSurface
, especially with #13359, but passing the queries seems out of scope. I am open to suggestions.
StrikeForceZero
force-pushed
the
dev/bevy_ui/ui_surface_promo_demo
branch
from
May 13, 2024 22:42
65fb529
to
03fb1fa
Compare
3 tasks
alice-i-cecile
added
C-Bug
An unexpected or incorrect behavior
A-UI
Graphical user interfaces, styles, layouts, and widgets
S-Waiting-on-Author
The author needs to make changes or address concerns before this can be merged
labels
May 15, 2024
StrikeForceZero
force-pushed
the
dev/bevy_ui/ui_surface_promo_demo
branch
from
June 23, 2024 02:50
03fb1fa
to
1e4816f
Compare
1 task
superseded by #16383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Bug
An unexpected or incorrect behavior
S-Waiting-on-Author
The author needs to make changes or address concerns before this can be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on:
[bevy_ui/layout] UiSurface update internal mappings #12804[bevy_ui/layout] Update internal mappings #16362Objective
Changed<Parent>
RemovedComponent<Parent>
Solution
layout_system
to handle the specified edge casesTesting
Changelog