Sysinfo plugin compilation has been fixed for disabled multi_threaded feature

[bugsweeper]

Objective

• Fixes Sysinfo plugin does not compile without multi_threaded feature #13957 .
• Sysinfo fails compilation of multi_threaded feature disabled, because single_threaded_task_pool::TaskPool::spawn returns FakeTask which can't contain future result, because it's just empty struct, but actualy for non wasm (for wasm32 it indeed can't do better, because uses wasm spawn method which allows only futures which outputs only empty tuple) it spawns future, gets it's task, waits while executor finishes, and return nothing (FakeTask), throwing away _task with result!

Solution

• For non wasm builds FakeTask contains result, which is used by Sysinfo.

Testing

• Built project with and without feature multi_threaded

[janhohenheim]

Worth thinking about how this interacts with #13889

[bugsweeper]

Worth thinking about how this interacts with #13889

PR you metioned also tries solve throwing away result, but has amount of work for wasm32 target, that is why that solution should be better. This PR conflicts with that PR, that is why we should wait some time for that PR.

[bugsweeper]

Looks like #13889, which I mentioned as better solution is not moving forward anymore

[janhohenheim]

Ping @JoJoJet, do you think we should wait for your PR?

[joseph-gio]

I can take some time this week to finish up that PR. I don't think it's very far from a mergeable state

[alice-i-cecile]

No longer blocked :)

[bugsweeper]

No longer blocked :)

@alice-i-cecile we can close this PR, and mark #13957 as resolved by #13889

[janhohenheim]

@bugsweeper have you verified that the compilation works with the given setup on main? If so, I can file the PR / issue accordingly later.

[bugsweeper]

@bugsweeper have you verified that the compilation works with the given setup on main? If so, I can file the PR / issue accordingly later.

Yes, I did ensured successfull compilation before asking for closing this PR