Skip to content

prepare next version: update regexes #14170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 3 commits into from
Jul 8, 2024
Merged

prepare next version: update regexes #14170

alice-i-cecile merged 3 commits into from
Jul 8, 2024

Conversation

@mockersf
Copy link
Member

@mockersf mockersf commented Jul 5, 2024

Objective

Solution

  • Update the regexes to work with the -dev suffix

@mockersf mockersf added the A-Meta About the project itself label Jul 5, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Jul 5, 2024
@alice-i-cecile alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Jul 5, 2024
janhohenheim
janhohenheim suggested changes Jul 5, 2024
View reviewed changes
janhohenheim
janhohenheim suggested changes Jul 5, 2024
View reviewed changes
janhohenheim
janhohenheim approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some minor requests, but if it works it works

@janhohenheim janhohenheim added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jul 6, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 8, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 8, 2024
Merged via the queue into bevyengine:main with commit 2553c3a Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@rlidwka rlidwka rlidwka left review comments

@janhohenheim janhohenheim janhohenheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Meta About the project itself C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mockersf @rlidwka @alice-i-cecile @janhohenheim