Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rodio requirement from 0.19 to 0.20 #16359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update rodio requirement from 0.19 to 0.20 #16359

wants to merge 1 commit into from

Conversation

mnmaita
Copy link
Member

@mnmaita mnmaita commented Nov 11, 2024

Objective

Solution

  • Updated rodio version requirement to 0.20.
  • Changelog

Testing

  • CI checks.

@mnmaita mnmaita added C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 11, 2024
@dependabot @mnmaita
Update rodio requirement from 0.19 to 0.20
96f6c21 
Updates the requirements on [rodio](https://github.com/RustAudio/rodio) to permit the latest version.
- [Changelog](https://github.com/RustAudio/rodio/blob/master/CHANGELOG.md)
- [Commits](RustAudio/rodio@v0.19.0...v0.20.1)

---
updated-dependencies:
- dependency-name: rodio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@mnmaita mnmaita mentioned this pull request Nov 11, 2024
Closed
@mnmaita
Copy link
Member Author

mnmaita commented Nov 12, 2024

The check-advisories failure is unrelated and also currently present in main. It will be fixed when notify-types gets bumped to v2.0.

@alice-i-cecile alice-i-cecile added the A-Audio Sounds playback and modification label Nov 12, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Nov 12, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 12, 2024
@alice-i-cecile
Copy link
Member

Bumping to 0.16: this shouldn't be shipped without testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Audio
Status: No status
Milestone
0.16
Development

Successfully merging this pull request may close these issues.
3 participants
@mnmaita @alice-i-cecile @BenjaminBrienen