Conversation
We can replace the untargeted form with a buffered event IMO. |
| @@ -1,4 +1,20 @@ | |||
| //! Event handling types. | |||
| //! Events are things that "happen" and can be processed by app logic. | |||
There was a problem hiding this comment.
Very nice. I'm pleased with how simple the diff is. I'm increasingly fond of this as the final form: this should give us 99% of the type-safety benefits without any complexity around mutually exclusive traits or a On variant for broadcast events.
Well, at least after Event -> ObserverEvent is done :)
|
I spent some time today writing up a focused little design doc for the ultimate split here: https://hackmd.io/@alice-i-cecile/SyuIWJPLxg I don't particularly care whether we do it in a single PR or across multiple, as long as we converge to our ideal form before we ship 0.17. |
SteveAlexander
left a comment
There was a problem hiding this comment.
Great to see improved types and improved docs. No comments.
There was a problem hiding this comment.
Much clearer docs :-)
|
Consolidating into #20731. |
Objective
triggerandtrigger_targets- by traitSolution
Check out the diff of the release notes.
Notes
BroadcastEventandEntityEventtogether, one must be implemented manually if you want both. This is probably okay as having both implemented is somewhat undesirable.EventtoObserverEvent.