Fix observers' access to relationship data during despawn_related#20258
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Jul 27, 2025
Merged
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jul 23, 2025
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I've left a suggestion for a clarifying comment, but this is fundamentally a good fix and I really appreciate the regression test.
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
Trashtalk217
approved these changes
Jul 24, 2025
Trashtalk217
added
S-Ready-For-Final-Review
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Jul 28, 2025
…evyengine#20258) # Objective - Fix issue where observers cannot access relationship data during `despawn_related` - Fixes bevyengine#20106 ## Solution - Changed `despawn_related` to use `get()` instead of `take()` to preserve relationship components during the despawn process - Collect entities into a vector before despawning to ensure the relationship data remains accessible to observers and hooks ## Testing - Added test `despawn_related_observers_can_access_relationship_data` that reproduces the issue scenario --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
tychedelia
pushed a commit
to tychedelia/bevy
that referenced
this pull request
Jul 31, 2025
…evyengine#20258) # Objective - Fix issue where observers cannot access relationship data during `despawn_related` - Fixes bevyengine#20106 ## Solution - Changed `despawn_related` to use `get()` instead of `take()` to preserve relationship components during the despawn process - Collect entities into a vector before despawning to ensure the relationship data remains accessible to observers and hooks ## Testing - Added test `despawn_related_observers_can_access_relationship_data` that reproduces the issue scenario --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
despawn_relateddespawn_relatedremoves relationship before calling observers and hooks #20106Solution
despawn_relatedto useget()instead oftake()to preserve relationship components during the despawn processTesting
despawn_related_observers_can_access_relationship_datathat reproduces the issue scenario