UI layout taffy sync fix #20270
Open
UI layout taffy sync fix #20270
+56
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugs. Instead of iterating through all the UI nodes three times, just walk the tree once. The previous fix bevyengine#20266 for the sync issues when `Node` component is added to an existing entity in a UI hierarchy only updated the taffy children of the added-node entity but its parent also needed to be updated.
ickshonpe
added
C-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
#20266 only fixed half the problem as it still left the UI node's parent's children out of sync.
Solution
The Taffy children of a UI node entity need to be updated not just on
Nodebeing added but also onNodebeing added to any of its children.Testing
Added a test
node_addition_should_sync_parent_and_childrenthat fails on main but passes with this PR.