Add methods Observer::with_entities and Observer::watch_entities #20274
+49
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
|
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
|
Please add this PR to the ongoing "observer overhaul" path note. |
alice-i-cecile
approved these changes
Jul 24, 2025
hukasu
approved these changes
Jul 24, 2025
gwafotapa
commented
Jul 24, 2025
| @@ -200,8 +200,7 @@ use crate::prelude::ReflectComponent; | |||
| /// | |||
| /// Note that the [`Observer`] component is not added to the entity it is observing. Observers should always be their own entities! | |||
| /// | |||
| /// You can call [`Observer::watch_entity`] more than once, which allows you to watch multiple entities with the same [`Observer`]. | |||
| /// serves as the "source of truth" of the observer. | |||
There was a problem hiding this comment.
Removed this mangled comment from the previous documentation about ObserverState. Or should it be updated instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
From time to time, I find myself observing multiple entities with the same
Observer. Right now this can only be achieved by callingwith_entityorwatch_entityfor each entity to watch. This PR provides versions of these two methods to watch multiple entities with a single call.Testing
Added a simple test.