-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
bevy_text::input module with no undo
#20763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…pport text editing.
* `TextInputAction` -> `TextEdit` * `TextInputActions` -> `TextEdits`
…he cursor. If there is a selection, overwrites it instead.
…d automatically with the `TextInputValue `text
…he associated types and systems.
…ts to `InvalidEdit` and `TextChanged` respectively.
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
Co-authored-by: Tim <[email protected]>
There's a lot in the example as this is the "low level" api - the follow-up PR has the "mid level" api for widgets, etc. Have a look at the |
mockersf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've played a bit with this PR and how to use it, and I think it introduces too many things at once, and some that doesn't interact well together.
I would prefer a simpler PR that would introduce a component that holds a cosmic buffer, and how to interact with it. Making it smaller would also improve the code organisation.
I don't think this should be merged in this state.
@mockersf Could you expand on this point? |
|
I've taken the time to split up |
|
This version has removed clipboard, filtering, masking, they will be re-added as separate PRs |
|
One element I would personally consider critical for an example is handling text input on a mobile browser, i.e. by popping open an on-screen keyboard when a text input is focused. This definitely feels like it belongs more in the eventual widget code, but it also would feel right to have that kind of support within Bevy (experimentally?) so work wouldn't need to be duplicated across many projects. |
Objective
bevy_text::inputmodule #20336 without undo/redo (see Temporarily upstream undo_2 #20489 to upstream theundo_2library)Testing