Skip to content

Conversation

@Zeophlite
Copy link
Contributor

@Zeophlite Zeophlite commented Aug 26, 2025

Objective

Testing

  • CI

ickshonpe and others added 30 commits July 30, 2025 18:25
* `TextInputAction` -> `TextEdit`
* `TextInputActions` -> `TextEdits`
…he cursor. If there is a selection, overwrites it instead.
…d automatically with the `TextInputValue `text
…ts to `InvalidEdit` and `TextChanged` respectively.
@Zeophlite
Copy link
Contributor Author

i am concerned about how much code is in the example. additionally, it seems this is just for 2d, can it be used in a ui in 3d or etc easily?

There's a lot in the example as this is the "low level" api - the follow-up PR has the "mid level" api for widgets, etc. Have a look at the examples/ in https://github.com/bevyengine/bevy/pull/20326/files .

Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've played a bit with this PR and how to use it, and I think it introduces too many things at once, and some that doesn't interact well together.

I would prefer a simpler PR that would introduce a component that holds a cosmic buffer, and how to interact with it. Making it smaller would also improve the code organisation.

I don't think this should be merged in this state.

@Zeophlite
Copy link
Contributor Author

and some that doesn't interact well together

@mockersf Could you expand on this point?

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 1, 2025
@alice-i-cecile alice-i-cecile modified the milestones: 0.17, 0.18 Sep 1, 2025
@Zeophlite
Copy link
Contributor Author

I've taken the time to split up input.rs

@Zeophlite
Copy link
Contributor Author

Zeophlite commented Sep 2, 2025

I have also taken the time to adopt #20326 , rebase onto this branch - see #20826

This was very helpful in fleshing out some concepts, such as "submit"

I appreciate any feedback on either repo on what parts should be pulled out to help merge these

@Zeophlite
Copy link
Contributor Author

This version has removed clipboard, filtering, masking, they will be re-added as separate PRs

@Zeophlite Zeophlite added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Sep 5, 2025
@rdrpenguin04
Copy link
Contributor

One element I would personally consider critical for an example is handling text input on a mobile browser, i.e. by popping open an on-screen keyboard when a text input is focused. This definitely feels like it belongs more in the eventual widget code, but it also would feel right to have that kind of support within Bevy (experimentally?) so work wouldn't need to be duplicated across many projects.

@alice-i-cecile alice-i-cecile modified the milestones: 0.18, 0.19 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible M-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants