Skip to content

Make ReflectEvent more accessible #22450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Jan 15, 2026
Merged

Make ReflectEvent more accessible #22450

alice-i-cecile merged 1 commit into from
Jan 15, 2026

Conversation

@ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Jan 9, 2026 •
edited
Loading

Objective

ReflectEventFns mentions being able to create custom implementations of it, but that's not actually currently possible.

Solution

  • Make ReflectEventFns::trigger field pub.
  • Add ReflectEvent::new and ReflectEvent::fn_pointers to enable creation of custom implementations.

Testing

Not sure what exactly we would be testing.

@ItsDoot ItsDoot added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 9, 2026
@ItsDoot ItsDoot added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 14, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 15, 2026
@alice-i-cecile alice-i-cecile added this to the 0.18.1 milestone Jan 15, 2026
Merged via the queue into bevyengine:main with commit 7576312 Jan 15, 2026
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.18.1

Development

Successfully merging this pull request may close these issues.

4 participants

@ItsDoot @kristoff3r @kfc35 @alice-i-cecile