Check clipping before recording hits on text nodes #22510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22507
Solution
Call
clip_check_recursivewhen checking text nodes for pointer hits.Testing
Made a branch of bevy_immediate using this fix, as @PPakalns suggested:
https://github.com/ickshonpe/bevy_immediate/tree/text-picking-clip-fix
Then
and select "Bevy Scrollareas" from the menu on the left.
You should see that scrolling the scrollable areas to the right no longer blocks interactions with the menu.