Skip to content

Comments

Check clipping before recording hits on text nodes#22510

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
ickshonpe:text-picking-clip-check
Jan 14, 2026
Merged

Check clipping before recording hits on text nodes#22510
alice-i-cecile merged 3 commits intobevyengine:mainfrom
ickshonpe:text-picking-clip-check

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 14, 2026

Objective

Fixes #22507

Solution

Call clip_check_recursive when checking text nodes for pointer hits.

Testing

Made a branch of bevy_immediate using this fix, as @PPakalns suggested:
https://github.com/ickshonpe/bevy_immediate/tree/text-picking-clip-fix

Then

cargo run --example demo

and select "Bevy Scrollareas" from the menu on the left.

You should see that scrolling the scrollable areas to the right no longer blocks interactions with the menu.

@ickshonpe ickshonpe added this to the 0.18.1 milestone Jan 14, 2026
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets A-Text Rendering and layout for characters A-Picking Pointing at and selecting objects of all sorts C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 14, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 14, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 14, 2026
Merged via the queue into bevyengine:main with commit 1b1458c Jan 14, 2026
40 checks passed
PPakalns pushed a commit to PPakalns/bevy that referenced this pull request Jan 27, 2026
# Objective

Fixes bevyengine#22507

## Solution

Call `clip_check_recursive` when checking text nodes for pointer hits.

## Testing

Made a branch of bevy_immediate using this fix, as @PPakalns suggested:
https://github.com/ickshonpe/bevy_immediate/tree/text-picking-clip-fix

Then
```
cargo run --example demo
```
and select "Bevy Scrollareas" from the menu on the left.

You should see that scrolling the scrollable areas to the right no
longer blocks interactions with the menu.
PPakalns pushed a commit to PPakalns/bevy that referenced this pull request Feb 15, 2026
# Objective

Fixes bevyengine#22507

## Solution

Call `clip_check_recursive` when checking text nodes for pointer hits.

## Testing

Made a branch of bevy_immediate using this fix, as @PPakalns suggested:
https://github.com/ickshonpe/bevy_immediate/tree/text-picking-clip-fix

Then
```
cargo run --example demo
```
and select "Bevy Scrollareas" from the menu on the left.

You should see that scrolling the scrollable areas to the right no
longer blocks interactions with the menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Picking Pointing at and selecting objects of all sorts A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI picking regression: doesn't correctly work when overflow: scroll clipped text content is on top of other content

4 participants