Add getter for SystemMeta::last_run field. #22516
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
approved these changes
Jan 15, 2026
andriyDev
added
C-Feature
Contributor
Author
|
@andriyDev thank you for the approval. Is it still possible to get this snuck into the 18.1 milestone? Or have I missed the window for that one? |
Contributor
|
That's a question for maintainers haha. Not sure what the policy is there tbh |
alice-i-cecile
approved these changes
Jan 15, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Non-breaking, extremely low risk. Into 0.18.1 it goes.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mockersf
approved these changes
Jan 15, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add
SytemMeta::get_last_run.Full description in issue: #22487
Solution
I added the getter. Since
TickisCopy, I just returned it by value. Pretty simple.Testing
implemented for: https://github.com/stinkytoe/shieldtank/blob/04d216a8db91749c9975c2756dc1a987e80b8aea/src/query/by_iid.rs#L117
example usages: