Fix depth prepass with msaa on webgpu#22531
Open
beicause wants to merge 1 commit intobevyengine:mainfrom
Open
Conversation
Contributor
|
Rather than using cfg, we should be checking adapter info for the current backend imo. |
Contributor
Author
This might not be necessary and is beyond the scope of this PR. We use feature gating for webgl/webgpu in many places and it doesn't have runtime checks overhead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #19148.
Should fix #19177, too, because wgpu webgl2 just doesn't support sampling depth or creating multisampled texture with
TEXTURE_BINDING.Solution
feature="webgl"andfeature="webgpu"can enable together(webgpu overrides webgl), so we should bind multisampled depth texture evenwebglfeature is enabled.Testing
Run
decalexample