Skip to content

Conversation

@aevyrie
Copy link
Member

@aevyrie aevyrie commented Jan 17, 2026

Objective

  • Luminance is a physical value that should be calculated in linear, not logarithmic (perceptual) space.

Solution

  • Don't convert from linear to srgb to do a luma calc.

@aevyrie aevyrie added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jan 17, 2026
@github-actions
Copy link
Contributor

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22565

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

@IQuick143 IQuick143 added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 17, 2026
Copy link
Contributor

@IQuick143 IQuick143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. (Pedantic: srgb is not logarithmic.)

@IQuick143 IQuick143 added the M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered label Jan 17, 2026
@IQuick143
Copy link
Contributor

I figured the two changed screenshots are an intentional consequence of the code.

@mockersf
Copy link
Member

I don't have an opinion: do we want to alter the examples to have a similar bloom as before or not?

@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Jan 17, 2026
@alice-i-cecile alice-i-cecile added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jan 17, 2026
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a small migration guide for this, even though it's a bug fix. Tracking down the cause of changes to bloom intensity and how to correct it will be a huge pain otherwise.

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 17, 2026
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@aevyrie aevyrie added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 19, 2026
@alice-i-cecile
Copy link
Member

Linter is mad at you but this looks good :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 20, 2026
Merged via the queue into bevyengine:main with commit 2ab9126 Jan 20, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants