Skip to content

Fix panic in update_viewport_render_target_size when despawning #22575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 1 commit into from
Jan 22, 2026
+8 −2
Merged

Fix panic in update_viewport_render_target_size when despawning #22575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/bevy_ui/src/widget/viewport.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@ use bevy_reflect::Reflect;
pub struct ViewportNode {
/// The entity representing the [`Camera`] associated with this viewport.
///
/// Note that removing the [`ViewportNode`] component will not despawn this entity.
/// Note: Removing the [`ViewportNode`] component will not despawn this
/// entity.
///
/// Note: Despawning the camera entity will leave a viewport node with an
/// invalid camera.
pub camera: Entity,
}

Expand Down Expand Up @@ -161,7 +165,9 @@ pub fn update_viewport_render_target_size(
mut images: ResMut<Assets<Image>>,
) {
for (viewport, computed_node) in &viewport_query {
let render_target = camera_query.get(viewport.camera).unwrap();
let Ok(render_target) = camera_query.get(viewport.camera) else {
continue;
};
let size = computed_node.size();

let Some(image_handle) = render_target.as_image() else {
Expand Down