Correctly check cpu data size not just descriptor. #22612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
A-Rendering
atlv24
approved these changes
Jan 20, 2026
IceSentry
approved these changes
Jan 20, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22609.
Solution
We need to also validate the cpu data size before we do any copies, etc. We'll ignore the users descriptor size if the configured it wrong. Not sure if we want to to warn or if there's any scenario where overwriting the size wouldn't be the right call.
Testing
fps_overlayno longer crashes.