-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Minimal responsive FontSize support
#22614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+568
−359
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
0639ce6
Added new FontSize type
ickshonpe 0113bd7
Added `Rem` unit support, for the moment resolved using the value of …
ickshonpe d6d5408
Updated text example
ickshonpe 1ef6b32
Added doc comment on how `Viewport` values are resolved for `Text2d`
ickshonpe ec4f8f3
improved font size doc comments
ickshonpe a9581df
Fixed `fps_overlay` so it compiles, layout still incorrect.
ickshonpe a2318e4
Added FontSize to bevy_text's prelude
ickshonpe f67bfcc
Updatged examples to use FontSize
ickshonpe 5ca48a6
Updated feathers
ickshonpe d83ec07
Updated release content
ickshonpe dafc52a
Migrate bevy_feathers
ickshonpe a3ae75a
updated migration guide.
ickshonpe d900aaf
Updated release content
ickshonpe 526fd5d
Send `create_text_measure` the logical viewport size, not physical.
ickshonpe a2da2cc
removed redundant as_vec2
ickshonpe e8981c6
Merge branch 'main' into font-size
ickshonpe 631dd3c
Fixed release content formatting
ickshonpe f61ca72
Fixed error in doc comment
ickshonpe 7ab2a5f
Fixed error in fps_overlay example
ickshonpe 6a562db
Fixed desktop_request_redraw module
ickshonpe 1c7c956
Added missing `FontSize` import to doc test.
ickshonpe 967322f
init `RemSize` in text2d test setup
ickshonpe de63313
Fixed doc test
ickshonpe 717563d
Merge branch 'main' into font-size
ickshonpe 5ac19f6
Merge branch 'main' into font-size
ickshonpe a16cd81
Merge branch 'main' into font-size
ickshonpe b3ac4bb
Merge branch 'main' into font-size
ickshonpe 2795139
Merge branch 'main' into font-size
ickshonpe e79fd17
Added `use_viewport_sizes` and `use_rem_sizes` flags to `ComputedText…
ickshonpe f06eb2b
Added accessor functions for new `ComputedTextBlock` flags
ickshonpe c8e1906
Added change detection for responsive font sizes with Text2d.
ickshonpe eaf3fc2
Removed accessor methods, added bool params to `needs_rerender` to p…
ickshonpe f3a2604
Fixed diagnostics_overlay
ickshonpe dcbc2e5
Added migration guide for `needs_rerender` changes.
ickshonpe 8d5da01
fixed mispelt filename
ickshonpe 76d75a6
Update release-content/release-notes/new_font_features.md
ickshonpe dbef8be
Refactored fontsize customization in the fps_overlay example and satu…
ickshonpe 187ede1
Merge branch 'font-size' of https://github.com/ickshonpe/bevy into fo…
ickshonpe b9817d7
Use =, no need for |=.
ickshonpe c2bd4a2
Added trailing line to migration guide
ickshonpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks inverted:
viewport_size_changedis computed with==, so it becomes true when the viewport is unchanged and false on the actual resize frame. I think this should be!=, otherwise viewport-based text may rerender unnecessarily and resize updates get delayed by a frame.