Fix FPS overlay system ordering ambiguity #22629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Jan 21, 2026
alice-i-cecile
added
C-Bug
ickshonpe
suggested changes
Jan 21, 2026
Contributor
Author
|
Good catch, thanks! Pushed a follow-up that adds update_frame_time_values to UpdateText as well - tested with the example and the conflict seems to be resolved now. |
ickshonpe
approved these changes
Jan 22, 2026
Contributor
ickshonpe
left a comment
ickshonpe
left a comment
There was a problem hiding this comment.
No more conflicts, looks good!
| .add_systems(Update, update_frame_time_values); | ||
| .add_systems( | ||
| Update, | ||
| update_frame_time_values.in_set(FpsOverlaySystems::UpdateText), |
Contributor
There was a problem hiding this comment.
I don't think there are any remaining problems, but I'm a bit unclear as to whether FrameTimeGraphPlugin is meant to be able to run independently of FpsOverlayPlugin or not. I guess it doesn't matter for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22571
Solution
Added
FpsOverlaySystemssystem set and explicitly orderedcustomize_overlayto run beforeupdate_text. This gets rid of the internal ambiguity warnings and also gives users a way to order their own systems against the overlay.Testing
Ran locally with ambiguity warnings enabled - no more internal overlay warnings. Didn't add a unit test since scheduling order is tricky to test in isolation.
To verify:
ScheduleBuildSettingsambiguity warnings.TextUiWriter.FpsOverlayPluginand confirm no overlay-related ambiguity warnings.