-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Replace tracing with bevy_log in bevy_render
#22652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tracing with bevy_log in bevy_render
#22652
Conversation
Replace direct tracing dependency with bevy_log in bevy_render for consistency with other bevy crates. Also adds `event` to bevy_log's tracing re-exports.
|
the changes are straightforward and compile on my machine - the CI changes are above my pay grade - any idea what's happening? |
This is pretty straightforward: looks like a missed import swap. The code is probably cfg-gated; hence why it's not showing up locally. Try a search within the bevy_render directory for tracing of "use tracing" to spot more that you missed :) |
IceSentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've been mildly annoyed by this for a while so I'm glad it's finally getting fixed!
Co-authored-by: IceSentry <[email protected]>
Head branch was pushed to by a user without write access
|
i updated to latest rust (1.93.0) to match CI and when i do |
We should probably file a bug upstream for this with a reproduction. |
Objective
Replace direct
tracingdependency withbevy_loginbevy_renderfor consistency with other bevy crates.This was split out from #22649 at @IceSentry's request.
Solution
bevy_logdependency tobevy_renderuse tracing::*imports withuse bevy_log::*tracingdependency frombevy_rendereventtobevy_log's tracing re-exports (needed byrenderer/mod.rs)Testing
Built with
--all-featuresand ran3d_sceneexample.