Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
After #18670, we have a
RemoteAllocator, but we don't have benchmarks for it compared to the non-remote allocator. This PR just adds those benchmarks.I don't know if we actually want these benchmarks, but it seems reasonable to have, and it took no time to make, so I figured I'd put it out there.
Solution
Add
entity_allocator_allocate_fresh_remoteandentity_allocator_allocate_reused_remotebenchmark groups.Testing
Showcase
Long story short, remote allocation is a little over 3 times slower than non-remote. All things considered, I think that's pretty good.