Skip to content

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jan 23, 2026

Timestamp queries have never worked for DLSS because I setup them up wrong when I initially wrote the code. This fixes it (and adds DLSS-RR time to the Solari example).

Basically we need to put the timestamp start on the command buffer before DLSS, and then the timestamp end on the command buffer right after DLSS.

Debug groups had to be removed because I can't use them across different command encoders.

@JMS55 JMS55 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jan 23, 2026
@JMS55 JMS55 added this to the 0.19 milestone Jan 23, 2026
@ChristopherBiscardi
Copy link
Contributor

Timestamps seem high? or am I reading this wrong?

Screenshot 2026-01-23 102750

also a bit harder to find the dlss-rr in nsight, but doable.

image

render doc is also crashing for me on a dlss-related issue afaict

Still 2026-01-23 104301_1 1 1

@JMS55
Copy link
Contributor Author

JMS55 commented Jan 23, 2026

Are you on a 4k monitor? Those numbers are not surprising for a 2080 TI. There's a table here: https://github.com/NVIDIA/DLSS/blob/main/doc/DLSS-RR%20Integration%20Guide.pdf (page 9).

Generally Solari's recommended minimum is going to be an RTX 4070 (especially once wgpu gets support for SER and OMM).

Renderdoc crash is interesting. Renderdoc doesn't support the DLSS extensions needed, but we also shouldn't be crashing. It's an unrelated bug to this PR though.

Copy link
Contributor

@ChristopherBiscardi ChristopherBiscardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you on a 4k monitor

1080p high-refresh rate (can go up to 240-ish).

If the numbers are expected for my hardware (which is out of the support bracket) then this is working afaict.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 24, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 24, 2026
Merged via the queue into bevyengine:main with commit 7b0a905 Jan 24, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants