Skip to content

Solari: Skip ReSTIR GI for smooth metallic surfaces #22671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Jan 24, 2026
Merged

Solari: Skip ReSTIR GI for smooth metallic surfaces #22671

alice-i-cecile merged 1 commit into from
Jan 24, 2026

Conversation

@JMS55
Copy link
Contributor

@JMS55 JMS55 commented Jan 23, 2026

Objective

  • Save perf on scenes with smooth metallic surfaces

Solution

  • Skip ReSTIR GI for these surfaces as the contribution will be zero anyways

Testing

  • Tested on a half metallic half non-metallic scene with varying roughness

@JMS55 JMS55 requested a review from SparkyPotato January 23, 2026 18:08
@JMS55 JMS55 added A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times labels Jan 23, 2026
@JMS55 JMS55 added this to the 0.19 milestone Jan 23, 2026
@JMS55 JMS55 added the D-Trivial Nice and easy! A great choice to get started with Bevy label Jan 23, 2026
@JMS55 JMS55 requested a review from alice-i-cecile January 23, 2026 19:12
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 24, 2026
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 24, 2026
Merged via the queue into bevyengine:main with commit 789891f Jan 24, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@SparkyPotato SparkyPotato SparkyPotato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Performance A change motivated by improving speed, memory usage or compile times D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

3 participants

@JMS55 @alice-i-cecile @SparkyPotato