Skip to content

move Skybox to bevy_light #22682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 2 commits into from
Jan 25, 2026
Merged

move Skybox to bevy_light #22682

alice-i-cecile merged 2 commits into from
Jan 25, 2026

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 24, 2026

Objective

  • Skybox is a main world component for scene definition, it shouldnt be in a rendering crate

Solution

  • Move it to bevy_light, alongside EnvironmentMapLight component sibling which lets it influence lighting.

Testing

  • skybox example works

@atlv24 atlv24 added A-Rendering Drawing game state to the screen M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 24, 2026
@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Jan 24, 2026
@alice-i-cecile alice-i-cecile requested a review from kfc35 January 24, 2026 19:58
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 25, 2026
Merged via the queue into bevyengine:main with commit 65abe44 Jan 25, 2026
42 checks passed
@atlv24 atlv24 deleted the ad/skybox-move branch January 26, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

3 participants

@atlv24 @kfc35 @alice-i-cecile