Skip to content

move transmission stuff to bevy_pbr #22687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 6 commits into from
Jan 25, 2026
Merged

move transmission stuff to bevy_pbr #22687

alice-i-cecile merged 6 commits into from
Jan 25, 2026

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 24, 2026

Objective

  • It makes no sense for bevy_camera::Camera3d to talk about transmission quality settings
  • transmission is not a core thing its a purely pbr thing, why is in bevy_core_pipelines
  • the implementation is generally scattered all over the place
  • ScreenSpaceTransmissionQuality is a resource for no reason at all

Solution

  • split out a struct for transmission stuff
  • consolidate stuff in bevy_pbr
  • make ScreenSpaceTransmissionQuality not a resource

Testing

transmission example looks good

@atlv24 atlv24 added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 24, 2026
@atlv24 atlv24 added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jan 24, 2026
mgi388
mgi388 reviewed Jan 24, 2026
View reviewed changes
crates/bevy_pbr/src/transmission/node.rs
if !transmissive_phase.items.is_empty() {
let screen_space_specular_transmission_steps =
camera_3d.screen_space_specular_transmission_steps;
transmission.screen_space_specular_transmission_steps;
Copy link
Contributor

@mgi388 mgi388 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atlv24 ScreenSpaceTransmission already specifies the “ScreenSpace” prefix in the component name so should the field names also lose the “screen_space_” prefix?

Copy link
Contributor Author

@atlv24 atlv24 Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to do a bunch of renames as a followup, i really dislike the current names but wanted to keep the diff small

kfc35
kfc35 approved these changes Jan 25, 2026
View reviewed changes
Copy link
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me for correctness

@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 25, 2026
Merged via the queue into bevyengine:main with commit 3ae32d5 Jan 25, 2026
42 checks passed
@atlv24 atlv24 deleted the ad/trans-mission branch January 26, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+3 more reviewers

@mgi388 mgi388 mgi388 left review comments

@kfc35 kfc35 kfc35 approved these changes

@ecoskey ecoskey ecoskey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atlv24 @kfc35 @alice-i-cecile @ecoskey @mgi388