Skip to content

Fix occlusion culling #22699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Jan 25, 2026
Merged

Fix occlusion culling #22699

alice-i-cecile merged 1 commit into from
Jan 25, 2026
+23 −11

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Jan 25, 2026

Objective

Solution

  • separate readonly storage binding for late phase to make wgpu happy

Testing

  • occlusion_culling example no longer crashes

finding this was very difficult lol

@atlv24 atlv24 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@atlv24 atlv24 added the P-Crash A sudden unexpected crash label Jan 25, 2026
@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Jan 25, 2026
@mockersf
Copy link
Member

mockersf commented Jan 25, 2026

also fixes bistro and caldera_hotel 🎉

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 25, 2026
Merged via the queue into bevyengine:main with commit d734e7f Jan 25, 2026
51 checks passed
@atlv24 atlv24 deleted the ad/fix-occlusion-culling branch January 26, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

example occlusion_culling crashes: Buffer with conflicting usages

4 participants

@atlv24 @mockersf @alice-i-cecile @IceSentry