Skip to content

Use an f32 scale_factor in TextPipeline #22703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 3 commits into from
Jan 25, 2026
Merged

Use an f32 scale_factor in TextPipeline #22703

alice-i-cecile merged 3 commits into from
Jan 25, 2026
+8 −8

Conversation

@ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 25, 2026 •
edited
Loading

Objective

TextPipeline's methods don't need to take an f64 scalefactor (cosmic text used to want f64s but not anymore), it just gets converted back to an f32.

Solution

  • Changed the types of the scale_factor parameters belonging to update_buffer, create_text_measure, and get_attrs from f64 to f32

  • Removed some needless conversions.

@ickshonpe
TextPipeline's methods don't need to take an f64 scalefactor (cosmi…
03fa3c3 
…c text used to want f64s but not anymore), it just gets converted back to an f32. Changed the type of those parameters to f32.
@ickshonpe ickshonpe added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Text Rendering and layout for characters S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@ickshonpe ickshonpe changed the title TextPipeline's methods don't need to take an f64 scalefactor (cosmi… Use an f32 scale_factor in TextPipeline Jan 25, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 25, 2026
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 25, 2026

Technically breaking, but not meaningfully enough to warrant a migration guide IMO.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 25, 2026
Merged via the queue into bevyengine:main with commit 95e80be Jan 25, 2026
38 checks passed
@ickshonpe
Copy link
Contributor Author

ickshonpe commented Jan 26, 2026

Technically breaking, but not meaningfully enough to warrant a migration guide IMO.

Yeah, I was going to add a note to one of the existing text migration guides but this was merged too quickly 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ickshonpe @alice-i-cecile