Skip to content

remove conditional that never runs #22711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alice-i-cecile merged 3 commits into from
Jan 27, 2026
+2 −13
Merged

remove conditional that never runs #22711

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6fee20
remove conditional that never runs
atlv24 Jan 26, 2026
2bd54d2
ci
atlv24 Jan 26, 2026
3427910
Merge branch 'main' into ad/yeet-thing
atlv24 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions crates/bevy_core_pipeline/src/core_3d/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,27 +690,16 @@ pub fn prepare_core_3d_depth_textures(
mut commands: Commands,
mut texture_cache: ResMut<TextureCache>,
render_device: Res<RenderDevice>,
opaque_3d_phases: Res<ViewBinnedRenderPhases<Opaque3d>>,
alpha_mask_3d_phases: Res<ViewBinnedRenderPhases<AlphaMask3d>>,
transparent_3d_phases: Res<ViewSortedRenderPhases<Transparent3d>>,
views_3d: Query<(
Entity,
&ExtractedCamera,
&ExtractedView,
Option<&DepthPrepass>,
&Camera3d,
&Msaa,
)>,
) {
let mut render_target_usage = <HashMap<_, _>>::default();
for (_, camera, extracted_view, depth_prepass, camera_3d, _msaa) in &views_3d {
if !opaque_3d_phases.contains_key(&extracted_view.retained_view_entity)
|| !alpha_mask_3d_phases.contains_key(&extracted_view.retained_view_entity)
|| !transparent_3d_phases.contains_key(&extracted_view.retained_view_entity)
{
continue;
};

for (_, camera, depth_prepass, camera_3d, _msaa) in &views_3d {
// Default usage required to write to the depth texture
let mut usage: TextureUsages = camera_3d.depth_texture_usages.into();
if depth_prepass.is_some() {
Expand All @@ -724,7 +713,7 @@ pub fn prepare_core_3d_depth_textures(
}

let mut textures = <HashMap<_, _>>::default();
for (entity, camera, _, _, camera_3d, msaa) in &views_3d {
for (entity, camera, _, camera_3d, msaa) in &views_3d {
let Some(physical_target_size) = camera.physical_target_size else {
continue;
};
Expand Down