Call AuthorizeAndPlayURI on main thread
#218
Conversation
haashem
changed the title
AuthorizeAndPlayURI on main thread which internally calls UIApplication.openURLAuthorizeAndPlayURI on main thread which internally calls UIApplication.openURL
ios/spotify_sdk.podspec
Outdated
| s.platform = :ios, '13.0' | ||
| s.ios.deployment_target = '13.0' |
There was a problem hiding this comment.
| s.platform = :ios, '13.0' | |
| s.ios.deployment_target = '13.0' | |
| s.platform = :ios, '12.0' | |
| s.ios.deployment_target = '12.0' |
In their readme they say "iOS 12 or higher"
There was a problem hiding this comment.
I had to use Task to call their async authorizeAndPlayURI method in the sync connectToSpotify method, which is only available on iOS 13.
There was a problem hiding this comment.
It would be great to maintain compatibility with iOS 12. Isn't there another way to call it on the main thread?
There was a problem hiding this comment.
I doubt they are supporting iOS 12, as you see the method is now using async keyword which is only available on iOS 13.
They are using modern syntax which is not available in iOS 12, so there is no way.
There was a problem hiding this comment.
There are 2 versions of the method. If you use the version with the completion handler you should be able to use it under iOS 12.
There was a problem hiding this comment.
Good point, but It's not possible to throw error from non-throwable completion block and I don't know a proper way. most Swift cool features are not supported in iOS 12. the last option is to use completion block for connectToSpotify, which I don't want to try.
Supporting iOS 12 is still needed? considering 6 version behind current iOS 18.
There was a problem hiding this comment.
I think we shouldn't be throwing at all here. You may replace throw with self.connectionStatusHandler?.connectionResult?(FlutterError(code: "spotifyNotInstalled", message: "Spotify app is not installed", details: nil)).
We match the iOS version support of the native SDK. When the official SDK drops iOS 12 we will drop it as well.
There was a problem hiding this comment.
I can work on it tomorrow, Thursday.
There was a problem hiding this comment.
Fyi: I fixed the linting issues, just rebase on the current main :). @haashem thanks for contributing to this package!
fotiDim
changed the title
AuthorizeAndPlayURI on main thread which internally calls UIApplication.openURLAuthorizeAndPlayURI on main thread
Fixed a bug caused by my previous PR.
Feel free to change PR title if needed.