[feature/new-dag-editor] part 4: Add the main component for the reactflow based DAG editor #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njbriggs
reviewed
Mar 28, 2025
| showFitView={false} | ||
| showInteractive={false} | ||
| > | ||
| {!isDisabled && ( |
There was a problem hiding this comment.
Looks like these are hidden when disabled. Does it make more sense to disable the components themselves?
There was a problem hiding this comment.
The showZoom, showFitView and showInteractive props of the reactflow.Controls component show/hide the built-in (in reactflow) implementation of these features. We have hidden them explicitly, as we are using the same buttons with our own controller logic.
The actual zoom, fit and lock buttons are not rendered when the editor is in disabled mode. (As implemented in the lines following this)
njbriggs
approved these changes
Mar 28, 2025
radhikav1
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the main component for the reactflow based DAG editor
Description
Part 4 of the set of changes implementing the new DAG editor for CDAP UI.
Links to the previous changesets:
In this PR, we add the main component for the reactflow based DAG editor, its controller code to interface with the angularjs controller and associated utilities. This PR also includes the code changes to export this react component for use in the angularjs codebase.
Though we import and reference the Node and Edge types (components) in this PR, they are not included here to keep the changeset small for ease of review. The reactflow Node and Edge type components follow a standard set of props, that all implementing components should follow, therefore the reviewers can assume that the references to these components here will follow the standard set of props (Defined in the reactflow docs).
This also includes minor changes to the
PipelineContextMenuandPipelineCommentsActionBtncomponents.PR Type
Links
Jira: CDAP-21142
Test Plan
NA. Not testable. Tests will be run when the complete feature branch is merged to develop
Screenshots
NA