-
Notifications
You must be signed in to change notification settings - Fork 623
Track tests in HasTests to support metadata needs #4833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track tests in HasTests to support metadata needs #4833
Conversation
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
Marked as No Release Notes instead of API Modification because there is not yet a release with this feature. |
797f20e
to
732b41f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't entirely understand why you're making this change, can you explain a little bit more in the PR description?
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
src/main/scala/chisel3/experimental/inlinetest/InlineTest.scala
Outdated
Show resolved
Hide resolved
Of course, the focus here is supporting metadata, e.g. Properties. I added
to the description and a test showing how this might be useful. |
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
HasTests
to track tests in buffer before elaboratingHasTests
module. At the moment,testName
is the only public member of theTestParameters
, but this may be expanded in the future.Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
and clean up the commit message.Create a merge commit
.